From ff7164b9ec0d056e0cbc2facfd699fe1db4ae562 Mon Sep 17 00:00:00 2001 From: Abdul Fatah Jamro Date: Fri, 3 Jul 2026 15:07:16 +0100 Subject: [PATCH] fix: resolve RAG manager search signature TypeError (#4994) * fix: resolve RAG manager search signature TypeError and adjust similarity threshold * fix: revert similarity threshold change to keep PR focused * test(rag): remove trailing whitespace --------- Co-authored-by: Alexandre Teixeira --- src/rag_manager.py | 4 ++-- tests/test_rag_search_signature.py | 22 ++++++++++++++++++++++ 2 files changed, 24 insertions(+), 2 deletions(-) create mode 100644 tests/test_rag_search_signature.py diff --git a/src/rag_manager.py b/src/rag_manager.py index a41608ecf..887030ee0 100644 --- a/src/rag_manager.py +++ b/src/rag_manager.py @@ -32,9 +32,9 @@ class RAGManager: logger.info("RAGManager initialized as wrapper for VectorRAG") # Delegate all methods to VectorRAG - def search(self, query: str, k: int = 5) -> List[Dict[str, Any]]: + def search(self, query: str, k: int = 5, owner: Optional[str] = None) -> List[Dict[str, Any]]: """Search for documents - delegates to VectorRAG.""" - return self.vector_rag.search(query, k) + return self.vector_rag.search(query, k, owner=owner) def index_personal_documents( self, diff --git a/tests/test_rag_search_signature.py b/tests/test_rag_search_signature.py new file mode 100644 index 000000000..eb6dbcd67 --- /dev/null +++ b/tests/test_rag_search_signature.py @@ -0,0 +1,22 @@ +import unittest +from unittest.mock import MagicMock, patch +from src.rag_manager import RAGManager + +class TestRAGManagerSearchSignature(unittest.TestCase): + @patch('src.rag_manager.VectorRAG') + def test_search_signature_accepts_owner(self, mock_vector_rag_class): + # Create a mock instance for VectorRAG + mock_vector_rag = MagicMock() + mock_vector_rag_class.return_value = mock_vector_rag + + # Initialize RAGManager + manager = RAGManager() + + # Test call with owner parameter + manager.search("test query", k=3, owner="user1") + + # Verify that search was called on the underlying vector_rag with the correct parameters + mock_vector_rag.search.assert_called_once_with("test query", 3, owner="user1") + +if __name__ == '__main__': + unittest.main()